[vlc-devel] [vlc-commits] Mark --language as obsolete

[Rémi Denis-Courmont]

Le mercredi 18 juillet 2012 14:16:33 Felix Paul Kühne, vous avez écrit :
> > That I don't call "functionality". This is a work-around an old bug that
> > is supposed to be fixed.
> 
> It is an often requested and needed feature on VLC's most popular
> platforms, despite being based on a hack. The proper fix would have
> retained the existing feature set.

The fix for the gettext bug is in the gettext code base.

> > To make things worse, the work-around itself featured several bugs.
> 
> Trac tickets?

Seriously? setlocale() is known to crash in multithread context, *especially* 
on MacOS, and it is a documented limitation. It's OK if you already forgot 
that small detail, and if you don't know the documentation, but don't expect 
me to compensate. And that's just one of the problems.

(...)
> Note that I'm not against the improvement or removal of old code. My only
> point is that we need a language switcher for the reasons you laid out
> yourself, so we got 2 options: re-implement it "the proper way" (I doubt
> that there is one, but feel free to enlighten me)

At least, MacOS, GNU/Linux and Windows (either Win32 or MSVCRT) all support 
thread-safe locales.

> or revert your changes.
> As Rafaël pointed out, I would have preferred if you had send a
> three-liner to vlc-devel announcing your plans (so you would have saved
> the spare time you spent on this) or at least the patches prior to
> merging, just like I do now for the contrib system and configure things.

Contrary to most other key developers, including you, I do send patches for 
review *when* I have doubts, not just when The Official Process requires me to 
send patches. As it happens, I typically do not get feedback, or just JB 
telling me to merge a week later.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis