[vlc-devel] [PATCH] audio_filter: introduce libavresample based filter

[Jean-Baptiste Kempf]

On Tue, Jun 05, 2012 at 01:49:49AM +0200, Luca Barbato wrote :
> +  AS_HELP_STRING([--enable-avresample],[libavresample sound resampling and conversion plugin (default enabled)]))

Isn't that auto?

> +    set_shortname (N_("avresample resampler"))
> +    set_description (N_("libavresample resampler") )

Do we really need 2 different names?

> +static enum AVSampleFormat vlcsampleformat_to_libav(vlc_fourcc_t codec) {

This is the reverse of GetVlcAudioFormat, right?
And the name is poorly choosen, IMVHO.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device