[vlc-devel] [PATCH] audio_filter: introduce libavresample based filter

[Luca Barbato]

On 05/06/12 12:18, Jean-Baptiste Kempf wrote:
> On Tue, Jun 05, 2012 at 01:49:49AM +0200, Luca Barbato wrote :
>> +  AS_HELP_STRING([--enable-avresample],[libavresample sound resampling and conversion plugin (default enabled)]))
> 
> Isn't that auto?

You are right.

> 
>> +    set_shortname (N_("avresample resampler"))
>> +    set_description (N_("libavresample resampler") )
> 
> Do we really need 2 different names?

I think we do not, should I keep description or shortname? (I do not
know which one is optional)

>> +static enum AVSampleFormat vlcsampleformat_to_libav(vlc_fourcc_t codec) {
> 
> This is the reverse of GetVlcAudioFormat, right?
> And the name is poorly choosen, IMVHO.

GetLibavAudioFormat sounds better?

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero