[vlc-devel] [PATCH 1/3] Audioscrobbler: Update the handshake protocol to the version 2.0.

[Samuel Pitoiset]

Hi,

Yes, I'll hardcoded the api-key and the secret-key via the C preprocessor.

> +
> +    /* generate a md5 hash of the api signature */
> +    InitMD5(&p_struct_md5);
> +    AddMD5(&p_struct_md5, (uint8_t*) psz_api_sig, strlen(psz_api_sig));
You should already know that size (no need to recompute the strlen).

Indeed, I agree with you, thanks for the remark.

On Mon, Feb 27, 2012 at 3:51 PM, Jean-Baptiste Kempf <jb at videolan.org>wrote:

> On Mon, Feb 27, 2012 at 04:50:12PM +0200, Rémi Denis-Courmont wrote :
> > Then they should be hard-coded via the C preprocessor.
>
> Yep, that's what we said on IRC, post-mail :-)
>
> Best regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>



-- 
Best regards,
Samuel Pitoiset.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120307/f304af44/attachment.html>