[vlc-devel] [PATCH]Equalizer, support other sampling rates than 44100 and 48000

Ron Wright logiconcepts819 at gmail.com
Sat Mar 10 22:34:19 CET 2012


I just realized that the label changing scheme wasn't so consistent when a
file or stream is paused and then resumed, so an extra Boolean variable has
been introduced to ensure that the settings only change from the "stopped"
state to the "playing" state.  I also discovered the need to add a global
variable to ensure that the labels are consistent when the bands setting in
the preferences window is changed between the start of the first playback
and the initialization of the extended panels window.  Otherwise, the
extended panels module will have incorrect center frequencies until the
next playback.

The updated module patch uses the term "VLC Bands" instead of "Classic VLC
Bands", removes the storage of the sampling frequency, and introduces the
additional global variable to ensure that the labels in the GUI are
consistent with the initialized center frequencies and coefficients in the
module.  The updated GUI patch simply fixes the consistency issues that I
just discovered.

Other issues in the GUI such as the use of var_Get* instead of var_Inherit*
and the use of QStrings instead of char arrays can be resolved later, since
the pre-existing code already has these issues.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120310/fba9502b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Improve-equalizer-gui.patch
Type: text/x-patch
Size: 5459 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120310/fba9502b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Improve-equalizer-module.patch
Type: text/x-patch
Size: 7155 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120310/fba9502b/attachment-0001.bin>


More information about the vlc-devel mailing list