[vlc-devel] [PATCH]Equalizer, support other sampling rates than 44100 and 48000

Rémi Denis-Courmont remi at remlab.net
Sat Mar 10 16:25:49 CET 2012


I think "vlc" is good enough. classic_?vlc seems needlessly long.

And you don't need to store i_rate. The input and output formats remain valid 
throughout the lifetime of the module instance.


By the way the preexisting UI code... It really should use 
var_Inherit(p_libvlc) instead of config_Get() so that command line parameters 
work. Also static QString are a bad idea as they require running code when 
loading and unloading the plugin. Static const char [] is a lot better. In 
general, I don't much fancy static C++ objects. Oh well, that's for another 
time.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis



More information about the vlc-devel mailing list