[vlc-devel] [PATCH]Equalizer, support other sampling rates than 44100 and 48000

[Ron Wright]

I have updated the equalizer module again with an improved calculation of
equalizer coefficients.  First, I replaced the subtraction of the two
cosines with a product of two sines using the sum-to-product formula.  This
significantly reduces the roundoff error due to floating point
cancellation.  Second, I made the root value twice the root value in
equ-xmms so that the resulting modified formulas for alpha, beta, and gamma
lead to more efficient calculations.

On Sat, Mar 10, 2012 at 4:36 PM, Jean-Baptiste Kempf <jb at videolan.org>wrote:

> On Sat, Mar 10, 2012 at 03:34:19PM -0600, Ron Wright wrote :
> > -        band_texts[i] = new QLabel( band_frequencies[i] + "\n00.0dB" );
> > +        band_texts[i] = new QLabel( iso_band_frequencies[i] + "\n0.0dB"
> );
>
> Why removing the extra 0 ?
>
>
The values do not show the extra zero when initialized, so that would be
why I removed the extra zero.


> > +    CONNECT( THEMIM->getIM(), playingStatusChanged( int ), this,
> > +             playingChanged( int ) );
>
> Connecting for all status changes for some UI band update seems overkill
> to me.
> Do you really need that?
>
>
Does this imply that I should not keep the labels consistent with the
initialized center frequencies in the module?  Or is there a better way to
keep them consistent?


> Best regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120310/c29a63d5/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Improve-equalizer-module.patch
Type: text/x-patch
Size: 7536 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120310/c29a63d5/attachment.bin>