[vlc-devel] [PATCH]Equalizer, support other sampling rates than 44100 and 48000

Jean-Baptiste Kempf jb at videolan.org
Fri Mar 16 00:18:37 CET 2012


Sorry for the late reply.

On Sat, Mar 10, 2012 at 07:23:03PM -0600, Ron Wright wrote :
> I have updated the equalizer module again with an improved calculation of
> equalizer coefficients.  First, I replaced the subtraction of the two
> cosines with a product of two sines using the sum-to-product formula.  This
> significantly reduces the roundoff error due to floating point
> cancellation.  Second, I made the root value twice the root value in
> equ-xmms so that the resulting modified formulas for alpha, beta, and gamma
> lead to more efficient calculations.

Ok.

> The values do not show the extra zero when initialized, so that would be
> why I removed the extra zero.

Well, this is to work-around another bug. It should not be in your
patch.

> Does this imply that I should not keep the labels consistent with the
> initialized center frequencies in the module?  Or is there a better way to
> keep them consistent?

A callback, I think.

Can you update the patch, but splitting core and UI?

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list