[vlc-devel] [PATCH] chorus_flanger.c : bit of cleanup

[Sukrit Sangwan]

>
>
> > +            if( pf_ptr <= p_sys->pf_delayLineStart + p_sys->i_channels )
> > +                f_diff = *(p_sys->pf_delayLineEnd + i_chan) - *(pf_ptr +
> > i_chan);
> > +            else
> > +                f_diff = *( pf_ptr - p_sys->i_channels + i_chan )
> > +                            - *( pf_ptr + i_chan );
> > *>>> although it was written to fix linear interpolation, i have still
> used
> > it because it wasn't the cause of noise.*
> > +            /* Linear Interpolation. */
> > +            f_temp = *( pf_ptr + i_chan ) + f_diff * f_frac;
> >              sanitize(&f_temp);
> > +            *( p_sys->pf_write + i_chan ) = p_in[i_chan] +
> > +                p_sys->f_feedbackGain * *(pf_ptr + i_chan);
>
> This needs further checking. Rem?
>
> I have left the interpolation part as it is.
I think i need to understand the concept well before fixing it. will do
asap.

I have splitted the patches and renamed them.

-- 
Regards
Sukrit Sangwan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120315/dff1e6f0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sine oscillator and callbacks in chorus_flanger.patch
Type: text/x-patch
Size: 10236 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120315/dff1e6f0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: description and help in stereo_widen.patch
Type: text/x-patch
Size: 1043 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120315/dff1e6f0/attachment-0001.bin>