[vlc-devel] [PATCH] chorus_flanger.c : bit of cleanup

Jean-Baptiste Kempf jb at videolan.org
Fri Mar 16 00:08:41 CET 2012

On 15/03/2012 08:44, Sukrit Sangwan wrote:
> I have splitted the patches and renamed them.

Please fix this:

../../../modules/audio_filter/chorus_flanger.c: In function 'DoWork':
../../../modules/audio_filter/chorus_flanger.c:257:19: warning: cast 
from function call of type 'double' to non-matching type 'int' 
../../../modules/audio_filter/chorus_flanger.c:249:32: warning: variable 
'f_frac' set but not used [-Wunused-but-set-variable]
../../../modules/audio_filter/chorus_flanger.c:249:20: warning: variable 
'f_diff' set but not used [-Wunused-but-set-variable]

And please avoid pf_ for floats names

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list