[vlc-devel] [vlc-commits] video_filter/scene.c: write pictures in a separate thread.

[Jean-Paul Saman]

On Thu, May 10, 2012 at 4:12 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> On Thu, 10 May 2012 14:44:17 +0200, Jean-Paul Saman <jpsaman at videolan.org>
> wrote:
>>> With luck, VLC will it get OOM-killed. Without it, the whole system
> will
>>> crash under heavy load.
>>
>> I could set a cap on the fifo, but how large should it then be?
>
> In my view, the use of FIFO is altogether wrong.
>
>>> Also I think the state machine can get into a deadlock now.
>>
>> Where do you think the deadlock is then? It did not run into it when
>> testing this entire morning.
>
> To be honest, the implicit reliance by the VLC project on volunteers to
> perform code reviews demotivates and annoys me, even more so in challenging
> economical times.
>
> On top of that, you have been active longer than I have, and you are a
> commercial developer. I don't think *your* customer(s) deserve *my* time
> and expertise.

FYI this is volunteer work. It is not backed by money.

> Please figure it out yourself.
fair

Kind Regards,
Jean-Paul Saman