[vlc-devel] Notify plugins
kwohl at myopera.com
Thu May 17 20:06:41 CEST 2012
On May 17, 2012, at 7:17 PM, David Fuhrmann wrote:
>>> At last, I just ran into the sort of crash Remi referred to. VLC does not crash every time a playlist item changes, I discovered the crash when there was only one item visible in the playlist.
>>> Perhaps its a stupid question, but could it be possible to work around the problem by delaying the problematic part with performSelector(OnThread) or something like that?
>> If you mean delaying the call to playlist_CurrentInput() until its safe, i don't know if that would work.
>> Attached is a patch that follows the recommendation made by Rémi Denis-Courmont in the first mail in this thread. It removes the item-change callback as well as some checks for the remaining item-current callback (otherwise no notifications would be shown). I tested it with some local files and it seems to work. One ramification from the removed input_item_IsPreparsed() check is that files opened directly from Finder only show the filename instead of the metadata.
> Yeah. I also saw that the VLC icon is displayed instead of the thumbnails every time now.
> Of course this is not the best solution, but perhaps its better than the crashes before.
Yes unfortunately, but it displays the metadata and the icon if i drag some files into the playlist and start them from there, also the additional notifications are gone.
More information about the vlc-devel