[vlc-devel] Notify plugins

[David Fuhrmann]

Hi,

Am 17.05.2012 um 18:57 schrieb Karlheinz Wohlmuth:

> Hi,
> 
> On May 15, 2012, at 9:16 PM, David Fuhrmann wrote:
> 
>> Hello,
>> 
>> Yeah, I already thought that the issue could be something like that. Thanks for fixing, now it works on my setup.
>> 
>> While the plugin seems to work somehow, they are a few problems I discovered: In some situations, an additional old item notification is followed by the new item notification, when the new one begins to play. Furthermore, I got a message while quitting.
> 
> yes, i saw that too. Did that not happen with the original code?

Sorry if my comment was somewhat unclear, this was only a general remark. The problem was already there before your changes.

> 
>> At last, I just ran into the sort of crash Remi referred to. VLC does not crash every time a playlist item changes, I discovered the crash when there was only one item visible in the playlist.
>> Perhaps its a stupid question, but could it be possible to work around the problem by delaying the problematic part with performSelector(OnThread) or something like that?
> 
> If you mean delaying the call to playlist_CurrentInput() until its safe, i don't know if that would work.
> 
> Attached is a patch that follows the recommendation made by Rémi Denis-Courmont in the first mail in this thread. It removes the item-change callback as well as some checks for the remaining item-current callback (otherwise no notifications would be shown). I tested it with some local files and it seems to work. One ramification from the removed input_item_IsPreparsed() check is that files opened directly from Finder only show the filename instead of the metadata.

Yeah. I also saw that the VLC icon is displayed instead of the thumbnails every time now.
Of course this is not the best solution, but perhaps its better than the crashes before.

Best,
David