[vlc-devel] [PATCH] Flac Packetizer issue

[Rémi Denis-Courmont]

Le mardi 15 mai 2012 15:39:38 Jean-Baptiste Kempf, vous avez écrit :
> The lack of channels seem to be blocking transcoding of flac files
> Ref #4179 #6400
> 
> This is not enough, it seems. Any idea what to do?
> ---
>  modules/packetizer/flac.c |   26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/modules/packetizer/flac.c b/modules/packetizer/flac.c
> index 1fef09a..5d1d5bd 100644
> --- a/modules/packetizer/flac.c
> +++ b/modules/packetizer/flac.c
> @@ -90,6 +90,27 @@ struct decoder_sys_t
>      unsigned int i_rate, i_channels, i_bits_per_sample;
>  };
> 
> +static const int pi_channels_maps[9] =
> +{
> +    0,
> +    AOUT_CHAN_CENTER,
> +    AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT,
> +    AOUT_CHAN_CENTER | AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT,
> +    AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_REARLEFT
> +     | AOUT_CHAN_REARRIGHT,
> +    AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER
> +     | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT,
> +    AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER
> +     | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT | AOUT_CHAN_LFE,
> +    AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER
> +     | AOUT_CHAN_REARLEFT | AOUT_CHAN_REARRIGHT | AOUT_CHAN_MIDDLELEFT
> +     | AOUT_CHAN_MIDDLERIGHT,
> +    AOUT_CHAN_LEFT | AOUT_CHAN_RIGHT | AOUT_CHAN_CENTER |
> AOUT_CHAN_REARLEFT +     | AOUT_CHAN_REARRIGHT | AOUT_CHAN_MIDDLELEFT |
> AOUT_CHAN_MIDDLERIGHT +     | AOUT_CHAN_LFE
> +};

This does not look valid. FLAC should have no more than 6 channels.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis