[vlc-devel] [vlc-commits] MP3: support free format

[Laurent Aimar]

Hi,

On Wed, May 30, 2012 at 01:57:58PM +0200, Jean-Baptiste Kempf wrote:
> vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Wed May 30 13:57:03 2012 +0200| [de7ab0663de8f6faa1c8c513b0e080cb274879a0] | committer: Jean-Baptiste Kempf
> 
> MP3: support free format
> 
> libmad Decoder is necessary for that.
> 
>      if( ((( h >> 21 )&0x07FF) != 0x07FF )   /* header sync */
> +        || (((h >> 19)&0x03) == 1 )         /* valid version ID ? */
 I don't think that's related nor correct.
Those two bit correspond to the flags:
 - mpeg 2.5
 - version (mpeg 1 vs 2)
And for me the 4 values are valid.

Regards,

-- 
fenrir