[vlc-devel] new aac encoder for review

[Rafaël Carré]

Hello,

Le 04/10/2012 22:20, Sergio M. Ammirata, Ph.D. a écrit :
> 
>  configure.ac                             |    6 +
>  include/vlc_codec.h                      |    3 +
>  modules/codec/aac.c                      |  551 ++++++++++++++++++++++++++++++
>  modules/stream_out/transcode/transcode.c |   20 +-
>  4 files changed, 578 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 49e0901..1681b3c 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2612,6 +2612,12 @@ dnl
>  PKG_ENABLE_MODULES_VLC([TWOLAME], [], [twolame], [MPEG Audio Layer 2 encoder], [auto], [], [], [ -DLIBTWOLAME_STATIC])
>  
>  dnl
> +dnl fdk-aac encoder plugin
> +dnl
> +PKG_ENABLE_MODULES_VLC([FDKAAC], [], [fdk-aac], [FDK-AAC encoder], [auto])
> +VLC_ADD_LIBS([FDKAAC],[ -lfdk-aac])
> +
> +dnl
>  dnl  QuickTime plugin
>  dnl
>  AC_ARG_ENABLE(quicktime,
> diff --git a/include/vlc_codec.h b/include/vlc_codec.h
> index beac8fd..0750292 100644
> --- a/include/vlc_codec.h
> +++ b/include/vlc_codec.h
> @@ -173,6 +173,9 @@ struct encoder_t
>  
>      /* Encoder config */
>      config_chain_t *p_cfg;
> +    
> +    /* Does the encoder need purging at EOF? */
> +    bool b_purge_required;
>  };

Can't you call pf_encode(NULL) instead ?