[vlc-devel] new aac encoder for review

[Sergio M. Ammirata, Ph.D.]

Here it is ..

1) Modules.am changes added to the patch
2) EncodeAudio function header changed from aout_buffer_t to block_t
3) Used the output p_block allocated with max output buffer size as the
buffer passed to the lib as suggested. This eliminated the need for the
memcpy.

Sergio

On 10/13/12 6:46 AM, "Ilkka Ollakka" <ileoo at videolan.org> wrote:

>On Wed, Oct 10, 2012 at 02:04:46PM -0400, Sergio M. Ammirata, Ph.D. wrote:
>>  configure.ac        |    5 +
>>  modules/codec/aac.c |  535
>>+++++++++++++++++++++++++++++++++++++++++++++++++++
>
>Misses Modules.am stuff?
>
>> +static block_t *EncodeAudio( encoder_t *p_enc, aout_buffer_t *p_buf );
>
>I think this has changed in current git since May to block_t. Sorry only
>noticed it now when I had time to check compiling and stuff.
>
>> +            vlc_memcpy( p_block->p_buffer, outbuf,
>>out_args.numOutBytes );
>
>Use plain memcpy? I was wondering why don't you allocate block before
>encode and give that buffer directly to aacEncEncode? That would save
>memcpy? You could tune block_i->buffer after encode anyway to be correct
>on output amount.
>
>-- 
>Ilkka Ollakka
>This is the tomorrow you worried about yesterday.  And now you know why.
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>http://mailman.videolan.org/listinfo/vlc-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fdkaac_vlc_encoder_module.patch
Type: application/octet-stream
Size: 23362 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20121014/bc7d0dfb/attachment.obj>