[vlc-devel] new aac encoder for review
Sergio M. Ammirata, Ph.D.
sergio.ammirata at sipradius.com
Wed Oct 10 20:04:46 CEST 2012
Here is another version of the patch with the corrections you suggested.
On 10/10/12 1:23 PM, "Ilkka Ollakka" <ileoo at videolan.org> wrote:
>On Wed, Oct 10, 2012 at 10:49:18AM -0400, Sergio M. Ammirata, Ph.D. wrote:
>> Answers below ...
>> On 10/10/12 3:32 AM, "Ilkka Ollakka" <ileoo at videolan.org> wrote:
>> >On Sat, Oct 06, 2012 at 02:02:06PM -0400, Sergio M. Ammirata, Ph.D.
>> Not in the public ones. The code expects you to use the numbers but I
>> found it too confusing to follow so I created these defs.
>> >> +
>> >> + add_bool( ENC_CFG_PREFIX "afterburner", true, AFTERBURNER_TEXT,
>> >> + AFTERBURNER_LONGTEXT, false )
>> >> + add_integer( ENC_CFG_PREFIX "signaling", SIGNALING_COMPATIBLE,
>> >> + SIGNALING_LONGTEXT, false )
>> >Aren't afterburner and signaling more advanced options? Not a big
>> >but that false means that they are visible everytime and considered
>> >basic options that user should/could always fiddle.
>> Yes, they should be changed to true. I did not know what that last value
>> >> + if ( p_aout_buf )
>> >This could use likely( p_aout_buf )
>> It is not unlikely, it actually happens at the end of every playlist
>> or when you shutdown VLC while playing a stream.
>likely/unlikely are there to tell if that if is usually true or usually
>false. Comparing execution count as whole encode if it only happens on
>EOF it's unlikely to be untrue?
>God created a few perfect heads. The rest he covered with hair.
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 22708 bytes
Desc: not available
More information about the vlc-devel