[vlc-devel] new aac encoder for review

Ilkka Ollakka ileoo at videolan.org
Sat Oct 13 12:46:32 CEST 2012

On Wed, Oct 10, 2012 at 02:04:46PM -0400, Sergio M. Ammirata, Ph.D. wrote:
>  configure.ac        |    5 +
>  modules/codec/aac.c |  535 +++++++++++++++++++++++++++++++++++++++++++++++++++

Misses Modules.am stuff?

> +static block_t *EncodeAudio( encoder_t *p_enc, aout_buffer_t *p_buf );

I think this has changed in current git since May to block_t. Sorry only
noticed it now when I had time to check compiling and stuff.

> +            vlc_memcpy( p_block->p_buffer, outbuf, out_args.numOutBytes );

Use plain memcpy? I was wondering why don't you allocate block before
encode and give that buffer directly to aacEncEncode? That would save
memcpy? You could tune block_i->buffer after encode anyway to be correct
on output amount.

Ilkka Ollakka
This is the tomorrow you worried about yesterday.  And now you know why.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20121013/b9b68606/attachment.sig>

More information about the vlc-devel mailing list