[vlc-devel] [PATCH] avcodec: disable threading by default

[Ilkka Ollakka]

On Sat, Sep 15, 2012 at 09:42:21PM +0300, Rémi Denis-Courmont wrote:
> Threading does not currently work with some codec profiles and is thus
> not suited as default. Threading is also known to deadlock in certain
> circumstances, such as if no data is ever received (a rather common
> scenario with network or DVB reception).

I think this would be better default for now, until multithreading issues
are solved in common use cases.

> Fixed avcodec version should be checked before this is re-enabled.
> ---
>  modules/codec/avcodec/avcodec.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/modules/codec/avcodec/avcodec.c b/modules/codec/avcodec/avcodec.c
> index 1adc2a2..2176b74 100644
> --- a/modules/codec/avcodec/avcodec.c
> +++ b/modules/codec/avcodec/avcodec.c
> @@ -159,7 +159,7 @@ vlc_module_begin ()
>  #endif
>  #if defined(FF_THREAD_FRAME)
>      add_obsolete_integer( "ffmpeg-threads" ) /* removed since 2.1.0 */
> -    add_integer( "avcodec-threads", 0, THREADS_TEXT, THREADS_LONGTEXT, true );
> +    add_integer( "avcodec-threads", 1, THREADS_TEXT, THREADS_LONGTEXT, true );
>  #endif
-- 
Ilkka Ollakka
If one studies too zealously, one easily loses his pants.
		-- A. Einstein.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120916/42a335af/attachment.sig>