[vlc-devel] Hard-coding space key to play / pause action

[David Fuhrmann]

Am 04.04.2013 um 12:07 schrieb Rémi Denis-Courmont <remi at remlab.net>:

> On Thu, 4 Apr 2013 11:24:57 +0200, David Fuhrmann
> <david.fuhrmann at gmail.com> wrote:
>> From a user point of view, IMHO some keys should just always trigger the
>> intuitive action such as escape (Exit fullscreen) and also space (toggle
>> play / pause). With this patch, space can be still assigned to another
>> action with preferences.
> 
> The current system is overkill. But at least it exhibits some consistency.
> Models I would consider include:
> - individual configuration per action (current model),
> - reduced set of configuration options,
> - a single list of profiles,
> - no configuration whatsoever.
> 
> I don't see why space should be special. Afterall the media keys are far
> more "obvious" and yet they are not hard-coded. And then the preference
> dialog is de facto the hotkeys documentation. Before keys can be
> hard-coded, some new documentation mechanism would be required.

Fair points.

> Besides it has practically no effects since the space key already defaults
> to play/pause.

The problem is that the macosx interface has command+p as the default hotkey and not space.
I don't know exactly what was the reason to choose a different hotkey here.

We could change the default hotkey of play/pause to space, but this somewhat breaks the look of the playback main menu.
Or we go back to the vlc 2.0 behavior and support both command+p and space as play/pause hotkeys.

Felix, what is your opinion about that?

Best,
David