[vlc-devel] [PATCH] Added a hotkey for clearing the playlist.

[Jean-Baptiste Kempf]

On 04 Apr, Martin Zeman wrote :
>      ACTIONID_PLAY_BOOKMARK9,
>      ACTIONID_PLAY_BOOKMARK10,
>      /* end of contiguous zone */
> +    ACTIONID_PLAY_CLEAR,
>      ACTIONID_SUBDELAY_UP,
>      ACTIONID_SUBDELAY_DOWN,
>      ACTIONID_SUBPOS_UP,

Why there?

> @@ -931,7 +937,7 @@ static void PlayBookmark( intf_thread_t *p_intf, int i_num )
>      char *psz_bookmark_name;
>      if( asprintf( &psz_bookmark_name, "bookmark%i", i_num ) == -1 )
>          return;
> -
> +    msg_Info( p_intf, "Play Bookmark");

Unrelated.

> +static void ClearPlaylist( intf_thread_t *p_intf )
> +{
> +    playlist_t *p_playlist = pl_Get( p_intf );
> +    playlist_Clear( p_playlist, pl_Unlocked );
> +}

DO you really need a function for those 2 lines, while it is used only
once?

> @@ -2600,6 +2610,7 @@ vlc_module_begin ()
>      add_string( "bookmark10", NULL,
>                BOOKMARK10_TEXT, BOOKMARK_LONGTEXT, false )
>  
> +
>  #define HELP_TEXT \
>      N_("print help for VLC (can be combined with --advanced and " \
>         "--help-verbose)")

Unrelated

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device