[vlc-devel] [PATCH] Added a hotkey for clearing the playlist.

[zemanm17 at fel.cvut.cz]

>On 04 Apr, Martin Zeman wrote :
>>      ACTIONID_PLAY_BOOKMARK9,
>>      ACTIONID_PLAY_BOOKMARK10,
>>      /* end of contiguous zone */
>> +    ACTIONID_PLAY_CLEAR,
>>      ACTIONID_SUBDELAY_UP,
>>      ACTIONID_SUBDELAY_DOWN,
>>      ACTIONID_SUBPOS_UP,
>
>Why there?

Since the previous ones are playlist related. I couldn't see any other kind of order in them.
If there is one, please let me know and I'll change it.

>> @@ -931,7 +937,7 @@ static void PlayBookmark( intf_thread_t *p_intf, int i_num )
>>      char *psz_bookmark_name;
>>      if( asprintf( &psz_bookmark_name, "bookmark%i", i_num ) == -1 )
>>          return;
>> -
>> +    msg_Info( p_intf, "Play Bookmark");
>
>Unrelated.

Sorry for this one. I forgot to delete this. I'll fix it in a new patch.

>> +static void ClearPlaylist( intf_thread_t *p_intf )
>> +{
>> +    playlist_t *p_playlist = pl_Get( p_intf );
>> +    playlist_Clear( p_playlist, pl_Unlocked );
>> +}
>
>DO you really need a function for those 2 lines, while it is used only
>once?

Ok, I'll change it.

>> @@ -2600,6 +2610,7 @@ vlc_module_begin ()
>>      add_string( "bookmark10", NULL,
>>                BOOKMARK10_TEXT, BOOKMARK_LONGTEXT, false )
>>  
>> +
>>  #define HELP_TEXT \
>>      N_("print help for VLC (can be combined with --advanced and " \
>>         "--help-verbose)")
>
>Unrelated

Will delete this one too.

Best regards

Martin Zeman