[vlc-devel] [PATCH] src: implement monotonic clock for osx

[Rémi Denis-Courmont]

On Tue, 10 Dec 2013 22:49:53 +0100, David Fuhrmann
<david.fuhrmann at gmail.com> wrote:
>> I fail to see how this fits in src/posix(/thread.c)
> 
> Yes, strictly speaking it should be moved into the darwin directory. But
> as most of the code in posix/thread.c is reused in darwin,

You have already forked the semaphore code. You need to fork the
cancellation and thread code to fix the infamous MacOS decoder bug. Now you
are forking the clock code, and consequently you need to fork the condition
variable code too.

So only the mutex code is left common, or about 10% of the code. Now sorry
but by definition of "most of code" means more than 50% thereof.

>> but most importantly I
>> fail to see how this can work without clock selection.
> 
> I suppose you are talking about the lack of vlc_clock_id definition?

No, I am referring to clock selection, not to monotonic clock.

> It works without that because this variable is only used in the cases
> _POSIX_CLOCK_SELECTION > 0 or _POSIX_TIMERS > 0.

It compiles because of that but it most certainly does not work.

-- 
Rémi Denis-Courmont
Sent from my collocated server