[vlc-devel] [PATCH] src: implement monotonic clock for osx

David Fuhrmann david.fuhrmann at gmail.com
Wed Dec 11 10:08:35 CET 2013


Am 11.12.2013 um 01:43 schrieb Rémi Denis-Courmont <remi at remlab.net>:

> On Tue, 10 Dec 2013 22:49:53 +0100, David Fuhrmann
> <david.fuhrmann at gmail.com> wrote:
>>> I fail to see how this fits in src/posix(/thread.c)
>> 
>> Yes, strictly speaking it should be moved into the darwin directory. But
>> as most of the code in posix/thread.c is reused in darwin,
> 
> You have already forked the semaphore code.

True.

> You need to fork the
> cancellation and thread code to fix the infamous MacOS decoder bug.

Who says that forking the thread implementation would fix an decoder bug?
I am really interested in your patch for this matter. And anyway, we already discussed 
that this is most likely because of a problem in Apples pthread implementation.
Seeing that its not a problem in the new Mavericks os anymore, I consider this already fixed
by Apple.

> Now you
> are forking the clock code, and consequently you need to fork the condition
> variable code too.

Could you elaborate, please?

>> 
>> I suppose you are talking about the lack of vlc_clock_id definition?
> 
> No, I am referring to clock selection, not to monotonic clock.

Then It looks like I did not got your point. So, please be more precise.

Best regards,
David


More information about the vlc-devel mailing list