[vlc-devel] [PATCH] Implemented libjpeg decoder module

[Jean-Baptiste Kempf]

On 13 Dec, Maxim Bublis wrote :
> +dnl  JPEG decoder module

Excellent idea! Please do the same for encoder...

> +#include <setjmp.h>

brr...

> +struct decoder_sys_t
> +{
> +    struct jpeg_error_mgr err;
> +    bool b_error;
> +    jmp_buf setjmp_buffer;
> +    decoder_t *p_dec;
> +};

You should clearly repack this structure.

> + * Probe the decoder and return score
> + */
> +static int OpenDecoder(vlc_object_t *p_this)
> +{
> +    decoder_t *p_dec = (decoder_t *)p_this;
> +
> +    if (p_dec->fmt_in.i_codec != VLC_CODEC_JPEG)
> +    {
> +    	return VLC_EGENERIC;

No tabs in source code

And you don't eed the {} 

> diff --git a/src/misc/fourcc.c b/src/misc/fourcc.c
> index 8cd821a..04a4c71 100644
> --- a/src/misc/fourcc.c
> +++ b/src/misc/fourcc.c
> @@ -351,8 +351,6 @@ static const staticentry_t p_list_video[] = {
>          A("mjpg"),
>          A("mJPG"),
>          A("mjpa"),
> -        A("jpeg"),
> -        A("JPEG"),
>          A("JFIF"),
>          A("JPGL"),
>          A("LJPG"),

Hmm, why?

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device