[vlc-devel] [PATCH] Implemented libjpeg decoder module

[Maxim Bublis]

> > +dnl  JPEG decoder module
>
> Excellent idea! Please do the same for encoder...
>

Do you mean to write video_output module using libjpeg's encoder?


> > +#include <setjmp.h>
>
> brr...
>
> > +struct decoder_sys_t
> > +{
> > +    struct jpeg_error_mgr err;
> > +    bool b_error;
> > +    jmp_buf setjmp_buffer;
> > +    decoder_t *p_dec;
> > +};
>
> You should clearly repack this structure.
>

Fixed in upcoming patch.


> No tabs in source code


Sorry for that, fixed in upcoming patch.


> And you don't eed the {}
>

Personally I prefer to enclose one-line code blocks with curly braces.


>
> > diff --git a/src/misc/fourcc.c b/src/misc/fourcc.c
> > index 8cd821a..04a4c71 100644
> > --- a/src/misc/fourcc.c
> > +++ b/src/misc/fourcc.c
> > @@ -351,8 +351,6 @@ static const staticentry_t p_list_video[] = {
> >          A("mjpg"),
> >          A("mJPG"),
> >          A("mjpa"),
> > -        A("jpeg"),
> > -        A("JPEG"),
> >          A("JFIF"),
> >          A("JPGL"),
> >          A("LJPG"),
>
> Hmm, why?
>

Image demuxer detects JPEG images incorrectly as Motion JPEG videos.
This lines dropped from Motion JPEG part only.


-- 
Maxim Bublis
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20131213/c3a1bda2/attachment.html>