[vlc-devel] [PATCH] Implemented libjpeg decoder module

[Jean-Baptiste Kempf]

On 13 Dec, Maxim Bublis wrote :
> > > +dnl  JPEG decoder module
> >
> > Excellent idea! Please do the same for encoder...
> 
> Do you mean to write video_output module using libjpeg's encoder?

No, but an encoder, so doing snapshots in jpeg, would not call
libavcodec, which is slow and has low encoding quality (see #5943)

> Personally I prefer to enclose one-line code blocks with curly braces.

Fine.

> > > diff --git a/src/misc/fourcc.c b/src/misc/fourcc.c
> > > index 8cd821a..04a4c71 100644
> > > --- a/src/misc/fourcc.c
> > > +++ b/src/misc/fourcc.c
> > > @@ -351,8 +351,6 @@ static const staticentry_t p_list_video[] = {
> > >          A("mjpg"),
> > >          A("mJPG"),
> > >          A("mjpa"),
> > > -        A("jpeg"),
> > > -        A("JPEG"),
> > >          A("JFIF"),
> > >          A("JPGL"),
> > >          A("LJPG"),
> >
> > Hmm, why?
> >
> 
> Image demuxer detects JPEG images incorrectly as Motion JPEG videos.
> This lines dropped from Motion JPEG part only.

Well, some video with mjpeg might use those FOURCC, so you would break
them.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device