[vlc-devel] [vlc-commits] auhal: prevent assertion failure on TPCircularBufferClear (close #10109)

[Felix Paul Kühne]

Hey David,

On 26.12.2013, at 21:32, David Fuhrmann <david.fuhrmann at gmail.com> wrote:

> 
> Am 26.12.2013 um 17:44 schrieb Felix Paul Kühne <git at videolan.org>:
>> 
>> +        if (availableBytes > 0)
> 
> Why this? Code works fine for availableBytes == 0, and < 0 should never happen, if the locks are set (as you just did in this patch). So this looks superfluous.

I hope that those locks are sufficient - however, considering that this lead to ~7,000 individual crashes since the release of version 2.1.2, I'd prefer to keep this in place to make sure, especially because the performance impact is insignificant.

Best regards,

Felix