[vlc-devel] [PATCH 1/6] avcodec: replacement for av_sample_fmt_is_planar

[Rafaël Carré]

Le 11/02/2013 17:24, Rémi Denis-Courmont a écrit :
> Le lundi 11 février 2013 16:28:42, Rafaël Carré a écrit :
>> ---
>>  configure.ac                    |    3 +++
>>  modules/codec/avcodec/avcodec.h |    9 +++++++++
>>  2 files changed, 12 insertions(+)
> 
> If this is a quick hack to ship VLC 2.0.6, I can pour some tap water in my fine 
> whine, and let you merge it.

OK, let's do this to get VLC 2.0.6 out.

> But if this is a precedent to cluttering the code 
> base with features checks for versioned libraries, I have to disagree.
> 
> doc/APIchanges, from both FFmpeg and libav, declare that 
> av_sample_fmt_is_planar() is available in lavu 51.17.0 onward.

Both libav and FFmpeg told me that that file is often incorrect.
It is obviously more incorrect in FFmpeg since they don't patch the
version numbers.
It's also quite incomplete so in effect you have to rely on git log to
find the version numbers that add new features.

> So I fail to
> see the need to have this check. Maybe you want to support intermediate 
> development versions of FFmpeg. I really think that this kind of hack is the 
> responsibility of distributions (including VLC contribs), not VLC upstream.
> 
> This is not even about FFmpeg vs libav. We don't generally support development 
> versions of underlying libraries. Broken version numbers is one of several 
> reasons not to bother doing so. I believe we have better use of our time and 
> motivation.

Maybe yes we should only support numbered releases from them ..