[vlc-devel] [PATCH 1/6] avcodec: replacement for av_sample_fmt_is_planar

Rémi Denis-Courmont remi at remlab.net
Tue Feb 12 18:28:56 CET 2013


On Tue, 12 Feb 2013 08:02:18 +0100, Rafaël Carré <funman at videolan.org>
> Both libav and FFmpeg told me that that file is often incorrect.
> It's also quite incomplete so in effect you have to rely on git log to
> find the version numbers that add new features.

Incorrect means that the version is wrong. Incomplete means that the
version is not specified. Those problems are different. Though it seems libav 
reviews have become stringent about versioning nowadays.

If there were more than one competing repositories of lav{u,c,f} with
self-consistent version numbers, then we would have to choose which one to
follow. Clearly, that would be a PITA and flamebait troll-friendly
discussion to hold. But I don't see how to avoid it. Accumulating a pile of
brittle hacks in configure.ac is not good either. Just because it would
displease some people is not an excuse for not addressing a _technical_
problem (that VLC developers are not responsible for, need I add).

Currently though, only libav.git has self-consistent numbers (and then,
arguably only the master branch). Thus I believe following libav.git
versions for external dependencies is the only sane choice at this point in 
time. There are no points in igniting the impeding flame war as yet.

> It is obviously more incorrect in FFmpeg since they don't patch the
> version numbers.

That would help if we decided to discard libav and support only FFmpeg. 
Otherwise, it is not a very good approach either. So long as FFmpeg git-merges
libav code, it should preserve the libav numbers. As a consequence, FFmpeg 
would need its own additional version numbers for non-libav features. But of 
course, that might hurt some egos, and require a little bit of build system 

In C header files, that would be trivial. In pkg-config, that requires a
separate set of .pc files though.

Rémi Denis-Courmont
Sent from my collocated server

More information about the vlc-devel mailing list