[vlc-devel] [PATCH] macosx: call input_changed in extensions

Felix Paul Kühne fkuehne.videolan at gmail.com
Sun Jan 6 20:49:54 CET 2013


Hello Josh,

I'm sorry for the long time it took me to respond. Thanks for your patch.

On 31.12.2012, at 04:52, Josh Watzman <jwatzman at jwatzman.org> wrote:

> This is obnoxiously complicated -- see comments in code. If anyone cares about
> playing_changed or meta_changed, something similar will probably have to be
> done.

Your argumentation is reasonable as well as the actual implementation. Could you please resent your patch without the lengthy comment? While it is an interesting read, a more simplified comment like "Due to constraints within NSAttributedString's main loop runtime handling, we need to wait for PlaylistItemChanged to finish" should be enough for follow-up developers.

Best regards,

Felix


More information about the vlc-devel mailing list