[vlc-devel] [PATCH] macosx: call input_changed in extensions

Josh Watzman jwatzman at jwatzman.org
Sun Jan 6 21:19:02 CET 2013

On 1/6/13 11:49 AM, Felix Paul Kühne wrote:
>> This is obnoxiously complicated -- see comments in code. If anyone cares about
>> playing_changed or meta_changed, something similar will probably have to be
>> done.
> Your argumentation is reasonable as well as the actual implementation. Could you please resent your patch without the lengthy comment? While it is an interesting read, a more simplified comment like "Due to constraints within NSAttributedString's main loop runtime handling, we need to wait for PlaylistItemChanged to finish" should be enough for follow-up developers.

Sure -- would it be acceptable to move it into the commit message, or
would you prefer I drop it entirely?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 896 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130106/3efc9781/attachment.sig>

More information about the vlc-devel mailing list