[vlc-devel] Adding Fetching and Idle in SD

[Rémi Denis-Courmont]

Le dimanche 20 janvier 2013 21:43:29, Francois Cartegnie a écrit :
> With most of lua SD, end user just sees nothing on activation.
> He also can't tell if there's a problem or just no result.

Your patch does not solve that problem in any way that I can tell. There are 
no error events.

> SD state is unknown until first items are added to playlist or unless
> you're watching the logs.
> I'd like to add Fetching & Idle events to get more info on SD states.

Most SD plugins run some kind of event loop.
They have no notion of fetching or idle state.

> The current problem is:
> - SD are private within playlist.
> - playlist doesn't emit events. (neither playlist_items)
> I don't see how the UI could place a listener for those events.
> Do we really need to only work with input at this level ?

Yes, we do. Playlist is not the only user of SD.

> @@ -201,6 +203,10 @@ typedef struct vlc_event_t
>          {
>              void * unused;
>          } services_discovery_ended;
> +        struct vlc_services_discovery_fetching_idle
> +        {
> +            const char * psz_name;
> +        } services_discovery_fetching, services_discovery_idle;

A name doesn't make sense here.
I don't think this event makes sense at all, but if it did, it would be a 
boolean.

-- 
Rémi Denis-Courmont
http://www.remlab.net/