[vlc-devel] [PATCH 1/8] Fix Metadata marshalling when sending the PropertiesChanged signal

[Alex Merry]

On 28/01/13 15:12, mirsal wrote:
>> +    input_thread_t *p_input;
>> +    if( ( p_input = playlist_CurrentInput( p_intf->p_sys->p_playlist ) ) ) {
>> +        PL_LOCK;
>> +        p_item = input_GetItem( p_input );
>> +        if( p_item )
>> +            GetInputMeta( p_item, container );
>> +        PL_UNLOCK;
>
> This does not look correct to me, the playlist lock should not be used
> to synchronize with an input thread.
>
> Removing the PL_LOCK/UNLOCK calls should be fine here.

>> +            return DBUS_HANDLER_RESULT_NEED_MEMORY;
>
> Use VLC's error constants

Yeah, I don't really know VLC's codebase.  TBH, this was even a bit of a 
crash course in libdbus for me :-)

Alex