[vlc-devel] [PATCH 1/8] Fix Metadata marshalling when sending the PropertiesChanged signal

[mirsal]

On Mon, 2013-01-28 at 16:58 +0000, Alex Merry wrote:
> On 28/01/13 15:12, mirsal wrote:
> >> +    input_thread_t *p_input;
> >> +    if( ( p_input = playlist_CurrentInput( p_intf->p_sys->p_playlist ) ) ) {
> >> +        PL_LOCK;
> >> +        p_item = input_GetItem( p_input );
> >> +        if( p_item )
> >> +            GetInputMeta( p_item, container );
> >> +        PL_UNLOCK;
> >
> > This does not look correct to me, the playlist lock should not be used
> > to synchronize with an input thread.
> >
> > Removing the PL_LOCK/UNLOCK calls should be fine here.
> 
> >> +            return DBUS_HANDLER_RESULT_NEED_MEMORY;
> >
> > Use VLC's error constants
> 
> Yeah, I don't really know VLC's codebase.

That would be VLC_ENOMEM

> TBH, this was even a bit of a crash course in libdbus for me :-)

Heh, quoting the docs:

"If you use this low-level API directly,
 you're signing up for some pain."

-- 
mirsal 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130128/1ed2ad6b/attachment.sig>