[vlc-devel] [PATCH] Intel Video QuickSync encoder support

Julien 'Lta' BALLET elthariel at gmail.com
Mon Jun 10 12:24:58 CEST 2013

Hi again,

>>> +    else if (sts < MFX_ERR_NONE) {
>>> +        msg_Err(enc, "Encoder not ready or error (%d), trying a reset...", sts);
>>> +        MFXVideoENCODE_Reset(sys->session, &sys->params);
>> Shouldn't it return NULL here?
> It should not. This is a problem with the encoder's feeding and
> doesn't mean the SyncOperation phase before didn't returned any
> interesting data.
> `return block;` will allready return NULL if the SyncOperation fails.

This reminded me that a few line earlier, it shouldn't return NULL
either. Thanks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Adds-Intel-QuickSync-Video-encoder.patch
Type: application/octet-stream
Size: 33737 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130610/46b82cc5/attachment.obj>

More information about the vlc-devel mailing list