[vlc-devel] [PATCH] Intel Video QuickSync encoder support

[Rafaël Carré]

Hello,

Le 10/06/2013 12:24, Julien 'Lta' BALLET a écrit :
> +static void qsv_set_block_ts(encoder_t *enc, encoder_sys_t *sys, block_t *block, mfxBitstream *bs)
> +{
> +    static uint64_t counter = 0;

This should be moved in context (sys_t), what happens if you have one
single process that runs 2 separate libvlc instances, or one libvlc
instance with 2 separate encoders?


+    mfxFrameSurface1 *frame = NULL;
+    mfxStatus        sts;
+
+
+

Excessive whitespace (there are other places btw) ?

+    if (pic) {
+        /* To avoid qsv -> vlc timestamp conversion overflow, we use
timestamp relative
+           to the first picture received. That way, vlc will overflow
before us.
+           (Thanks to funman for the idea) */
+        if (!sys->offset_pts) // First frame
+            sys->offset_pts = pic->date;
+        pic->date -= sys->offset_pts;


Since we are on whitespace, git warns about this:

Applying: Adds Intel QuickSync Video encoder
/media/dev/vlc/.git/rebase-apply/patch:793: new blank line at EOF.
+
warning: 1 line adds whitespace errors.