[vlc-devel] [PATCH] Improve performance of zvbi subtitles

[Rémi Denis-Courmont]

   Hello,

Looks good but...

diff --git a/modules/codec/zvbi.c b/modules/codec/zvbi.c
index 2a91f88..abe8c3e 100644
--- a/modules/codec/zvbi.c
+++ b/modules/codec/zvbi.c
@@ -567,8 +584,38 @@ static void EventHandler( vbi_event *ev, void *user_data 
)
         msg_Dbg( p_dec, "Network ID changed" );
 }
 
+static int get_first_visible_row( vbi_char *p_text, int rows, int columns)
+{
+    int i;
+
+    for ( i = 0; i < rows * columns; i++ )

Please use C++/C99 style for-loops in new code.

+    {
+        if ( p_text[i].opacity != VBI_TRANSPARENT_SPACE )
+        {
+            return i / columns;
+        }
+    }
+
+    return rows;
+}
+
+static int get_last_visible_row( vbi_char *p_text, int rows, int columns)
+{
+    int i;
+
+    for ( i = rows * columns - 1; i >= 0; i-- )
+    {
+        if (p_text[i].opacity != VBI_TRANSPARENT_SPACE)
+        {
+            return ( i + columns - 1) / columns;
+        }
+    }
+
+    return 0;
+}
+

-- 
Rémi Denis-Courmont
http://www.remlab.net/