[vlc-devel] [vlc-commits] avformat: don't mark buffer as need to be writable, as we don' t write into it directly

[Rafaël Carré]

Hello,

Le 17/03/2013 16:12, Ilkka Ollakka a écrit :
> vlc | branch: master | Ilkka Ollakka <ileoo at videolan.org> | Fri Mar 15 12:06:36 2013 +0200| [75890fb5e9086d91e92ca6d9abb13a307278238d] | committer: Ilkka Ollakka
> 
> avformat: don't mark buffer as need to be writable, as we don't write into it directly
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=75890fb5e9086d91e92ca6d9abb13a307278238d
> ---
> 
>  modules/demux/avformat/mux.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/demux/avformat/mux.c b/modules/demux/avformat/mux.c
> index b8734d5..26d476a 100644
> --- a/modules/demux/avformat/mux.c
> +++ b/modules/demux/avformat/mux.c
> @@ -122,7 +122,7 @@ int OpenMux( vlc_object_t *p_this )
>  
>      p_sys->io = avio_alloc_context(
>          p_sys->io_buffer, p_sys->io_buffer_size,
> -        1, p_mux, NULL, IOWrite, IOSeek );
> +        0, p_mux, NULL, IOWrite, IOSeek );
>  
>      p_sys->oc->pb = p_sys->io;
>      p_sys->oc->nb_streams = 0;

This commit broke mkv muxing:

ef867ffde25e68a6f75a95124172507e  Mr_MrsSmith-h264_aac.mp4

cvlc Mr_MrsSmith-h264_aac.mp4 --sout=lol.mkv causes an infinite loop.

What was the rationale behind this?