[vlc-devel] [PATCH] fix video playback on contextes with width and height differing from coded_width and coded_height

[Vittorio Giovara]

On Thu, Jun 27, 2013 at 11:25 PM, Vittorio Giovara <
vittorio.giovara at gmail.com> wrote:

> On Thu, Jun 27, 2013 at 9:28 PM, Rémi Denis-Courmont <remi at remlab.net>wrote:
>
>> Le jeudi 27 juin 2013 18:46:16, Vittorio Giovara a écrit :
>> >  This patch is needed when either container or bitstream impose some
>> > limitation on the final video size. Apparently it exposes a little
>> problem
>> > with OSD in which text is rendered with the display aspect ratio instead
>> > of the orignal one.
>>
>> OSD or bitmap subtitles or both? This can be a bug in the video output
>> core,
>> in the blend plugin or in the video output plugin (if it supports alpha
>> blending in display hardware).
>>
>
> I haven't tried with normal subtitles, I noticed that with a file whose
> coded_height is twice as much height pressing 'a' to change the aspect
> ratio the message that usually appears at the top is displayed at half
> height too.
> I looked at the video output core module but didn't find anything
> interesting, maybe it's really the blend (in modules/video_filter/blend.cpp
> right?).
>

So, I've dug this in a few output modules and analysed the core: so far I
just got some success in vout_subpictures.c where setting
i_original_picture_width (and height) shows the OSD at the right position
but at the wrong size (twice as much).
I also played with the values of the subsequent spu_scale_createq call, and
got an OSD at the right size but wrong position.

I'm open for suggestion.
Vittorio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130628/b98341d8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: subpic_origsize.diff
Type: application/octet-stream
Size: 737 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130628/b98341d8/attachment.obj>