[vlc-devel] [PATCH 5/5] vlccore: fix a warning on OS/2

[Rémi Denis-Courmont]

Le samedi 2 mars 2013 19:23:05, KO Myung-Hun a écrit :
> Rémi Denis-Courmont wrote:
> > Le samedi 2 mars 2013 17:11:10, KO Myung-Hun a écrit :
> >> -----
> >> os2/thread.c: In function 'vlc_cond_timedwait':
> >> os2/thread.c:329: warning: 'return' with no value, in function returning
> >> non-voi d
> >> -----
> >> ---
> >> 
> >>  src/os2/thread.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >> 
> >> diff --git a/src/os2/thread.c b/src/os2/thread.c
> >> index 10072aa..6ea4dd5 100644
> >> --- a/src/os2/thread.c
> >> +++ b/src/os2/thread.c
> >> @@ -326,7 +326,7 @@ int vlc_cond_timedwait (vlc_cond_t *p_condvar,
> >> vlc_mutex_t *p_mutex, if (!p_condvar->hev)
> >> 
> >>      {   /* FIXME FIXME FIXME */
> >>      
> >>          msleep (50000);
> >> 
> >> -        return;
> >> +        return ETIMEDOUT;
> > 
> > I don't think you can claim a time out that did not yet occur.
> 
> Then, what is proper value ? 0 ?

Win32 returns zero there. I think spurious wake-ups are permitted, spurious 
time-outs are not.

-- 
Rémi Denis-Courmont
http://www.remlab.net/