[vlc-devel] [PATCH 5/5] vlccore: fix a warning on OS/2

[KO Myung-Hun]

Rémi Denis-Courmont wrote:
> Le samedi 2 mars 2013 19:23:05, KO Myung-Hun a écrit :
>> Rémi Denis-Courmont wrote:
>>> Le samedi 2 mars 2013 17:11:10, KO Myung-Hun a écrit :
>>>> -----
>>>> os2/thread.c: In function 'vlc_cond_timedwait':
>>>> os2/thread.c:329: warning: 'return' with no value, in function returning
>>>> non-voi d
>>>> -----
>>>> ---
>>>>
>>>>  src/os2/thread.c |    2 +-
>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/src/os2/thread.c b/src/os2/thread.c
>>>> index 10072aa..6ea4dd5 100644
>>>> --- a/src/os2/thread.c
>>>> +++ b/src/os2/thread.c
>>>> @@ -326,7 +326,7 @@ int vlc_cond_timedwait (vlc_cond_t *p_condvar,
>>>> vlc_mutex_t *p_mutex, if (!p_condvar->hev)
>>>>
>>>>      {   /* FIXME FIXME FIXME */
>>>>      
>>>>          msleep (50000);
>>>>
>>>> -        return;
>>>> +        return ETIMEDOUT;
>>>
>>> I don't think you can claim a time out that did not yet occur.
>>
>> Then, what is proper value ? 0 ?
> 
> Win32 returns zero there. I think spurious wake-ups are permitted, spurious 
> time-outs are not.
> 

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.22 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-vlccore-fix-a-warning-on-OS-2.patch
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130303/baddecec/attachment.ksh>