[vlc-devel] [PATCH] vimeo playback now hides user agent automatically

[Rémi Denis-Courmont]

Le mercredi 6 mars 2013 22:11:39, Stephen G. Parry a écrit :
> So now we are adjusting patches so the _patch_ is easier to read, at the
> expense of code readability? I have done as you requested, but I was
> always taught not to hide 'early out returns'; ie. where possible a
> function should exit at the end & where not you should at least ensure
> the flow of control was still obvious. The change you requested has
> hidden the flow of control.

I don't know what this is about.

But in general, I must say that early returns are much easier to read, 
especially in case of error. The code flow can be very hard to read when there 
is a lot of nested and/subsequent if statements just for the sake of keeping a 
sole return statement.

-- 
Rémi Denis-Courmont
http://www.remlab.net/