[vlc-devel] [PATCH] vimeo playback now hides user agent, automatically
Stephen G. Parry
sgparry at mainscreen.com
Thu Mar 7 18:36:33 CET 2013
I suspect there is no one perfect way of doing these things.
Is the new patch OK to be committed though?
On 07/03/2013 11:00, vlc-devel-request at videolan.org wrote:
> Message: 16 Date: Wed, 6 Mar 2013 22:26:35 +0200 From: " R?mi
> Denis-Courmont" <remi at remlab.net> To: vlc-devel at videolan.org Subject:
> Re: [vlc-devel] [PATCH] vimeo playback now hides user agent
> automatically Message-ID: <201303062226.35638 at leon.remlab.net>
> Content-Type: Text/Plain; charset="iso-8859-1" Le mercredi 6 mars 2013
> 22:11:39, Stephen G. Parry a ?crit :
>> > So now we are adjusting patches so the _patch_ is easier to read, at the
>> > expense of code readability? I have done as you requested, but I was
>> > always taught not to hide 'early out returns'; ie. where possible a
>> > function should exit at the end & where not you should at least ensure
>> > the flow of control was still obvious. The change you requested has
>> > hidden the flow of control.
> I don't know what this is about.
> But in general, I must say that early returns are much easier to read,
> especially in case of error. The code flow can be very hard to read when there
> is a lot of nested and/subsequent if statements just for the sake of keeping a
> sole return statement.
> -- R?mi Denis-Courmont http://www.remlab.net/
More information about the vlc-devel