[vlc-devel] [vlc-commits] dbus: Fix handling of input events and remove memleaks

Rémi Denis-Courmont remi at remlab.net
Mon Mar 11 11:16:48 CET 2013


On Sun, 10 Mar 2013 17:42:51 +0100 (CET), git at videolan.org (Mirsal
Ennaime)
wrote:
> diff --git a/modules/control/dbus/dbus.c b/modules/control/dbus/dbus.c
> index 844161d..4958f98 100644
> --- a/modules/control/dbus/dbus.c
> +++ b/modules/control/dbus/dbus.c
> @@ -904,10 +904,10 @@ static int InputIntfEventCallback( intf_thread_t  
> *p_intf,
>              break;
>          case INPUT_EVENT_ITEM_META:
>              p_info->signal = SIGNAL_INPUT_METADATA;
> -            return VLC_SUCCESS;
> +            break;
>          case INPUT_EVENT_RATE:
>              p_info->signal = SIGNAL_RATE;
> -            return VLC_SUCCESS;
> +            break;
>          case INPUT_EVENT_POSITION:
>              /* Detect seeks
>               * XXX: This is way more convoluted than it should be... */

Hmm, did you check this? The surrounding code is very different from
2.1...

-- 
Rémi Denis-Courmont
Sent from my collocated server



More information about the vlc-devel mailing list