[vlc-devel] [vlc-commits] dbus: Fix handling of input events and remove memleaks

[mirsal]

On Mon, 2013-03-11 at 11:16 +0100, Rémi Denis-Courmont wrote:
> On Sun, 10 Mar 2013 17:42:51 +0100 (CET), git at videolan.org (Mirsal
> Ennaime)
> wrote:
> > diff --git a/modules/control/dbus/dbus.c b/modules/control/dbus/dbus.c
> > index 844161d..4958f98 100644
> > --- a/modules/control/dbus/dbus.c
> > +++ b/modules/control/dbus/dbus.c
> > @@ -904,10 +904,10 @@ static int InputIntfEventCallback( intf_thread_t  
> > *p_intf,
> >              break;
> >          case INPUT_EVENT_ITEM_META:
> >              p_info->signal = SIGNAL_INPUT_METADATA;
> > -            return VLC_SUCCESS;
> > +            break;
> >          case INPUT_EVENT_RATE:
> >              p_info->signal = SIGNAL_RATE;
> > -            return VLC_SUCCESS;
> > +            break;
> >          case INPUT_EVENT_POSITION:
> >              /* Detect seeks
> >               * XXX: This is way more convoluted than it should be... */
> 
> Hmm, did you check this? The surrounding code is very different from
> 2.1...

I did:

This patch does fix rate and metadata change events and removes leaks in
a couple of common cases without breaking anything.

The code is still leaking memory on error paths in 2.0, though.



regards,

-- 
mirsal 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20130311/8be60616/attachment.sig>