[vlc-devel] [PATCH] Revert "Switch smbclient detection to pkg-config"

[Zoran Turalija]

On Fri, Mar 29, 2013 at 07:29:57PM +0100, Nicolas Chauvet wrote:
> 
> 2013/3/29 Zoran Turalija <zoran.turalija at gmail.com>
> 
>     ...
>     > If there is a bug in Debian or Ubuntu, fix it or work around it in Debian
>     or
>     > Ubuntu.
> 
>     Sure, I said that already on IRC. At least, part about whose bug it is.
>     But, if you just send message - "fix upstream", it wont hide the fact that
>     783ebff129 commit just broke on logic "don't break something that wasnt
>     broken
>     before."
> 
> What is currently broken "without" the patch is samba4 headers that are now
> installed in a path not accessible by default by the compiler. So it may break
> newer version of most distro.

So, right thing to do is fix samba4 support, not break samba3 for ubuntu/debian,
that "was working before" - that is the premise.

Compare it with libav/ffmpeg support. There are people with older version of these
libs, and people with newer versions. When VLC pulls newer version, it does not
leave people with older versions behind. Note, I'm not comparing configure detection
with different version of these libs; rather I'm comparing support for older things
that worked and are working fine even now, just because there is a newer one that
changed things to the better or worse.

-- 
Kind regards,
Zoran Turalija