[vlc-devel] [PATCH] Revert "Switch smbclient detection to pkg-config"

[Rémi Denis-Courmont]

Le vendredi 29 mars 2013 21:09:44, Zoran Turalija a écrit :
> So, right thing to do is fix samba4 support, not break samba3 for
> ubuntu/debian,

Right thing to do is fix Debian/Ubuntu.

> that "was working before" - that is the premise.

That is not my premise.

> Compare it with libav/ffmpeg support. There are people with older
> version of these libs, and people with newer versions. When VLC pulls
> newer version, it does not leave people with older versions behind.

Actually, it does exactly that. We don't usually support more than 2-3 major 
libav* versions at a time, if only to keep #ifdef hackery to a reasonable 
level.

It's not our problem if people refuse to upgrade their libraries, especially 
those like libav, or worse FFmpeg, with poor backward source-level 
compatibility.

> Note, I'm not comparing configure detection with different version of
> these libs; rather I'm comparing support for older things that worked
> and are working fine even now, just because there is a newer one that
> changed things to the better or worse.

Again, you are wrong. VLC does increase its versions requirements for 
underlying libraries regularly, especially for libavcodec. You can check the 
commit logs to see for yourself.

-- 
Rémi Denis-Courmont
http://www.remlab.net/