[vlc-devel] [PATCH] Revert "Switch smbclient detection to pkg-config"

[Rémi Denis-Courmont]

Le vendredi 29 mars 2013 20:05:54, Zoran Turalija a écrit :
> But, if you just send message - "fix upstream", it wont hide the fact that
> 783ebff129 commit just broke on logic "don't break something that wasnt
> broken before."

It did not break the logic. It cleaned it up *and* it fixed it (since it was 
indeed broken as Nicolas explained).

> Maybe that is not the motto of this open source project?

The point of open-source pretty much is that you can modify (including fix) 
upstream, actually. If you think it is a bug in VLC, you are free to fork VLC 
and put your fix it. If you think it is a bug in Ubuntu, you are similarly free 
to get the package sources, fix them and rebuild.

> And it is user unfriendly. For all current Ubuntu/Debian users (excluding
> Debian experimental/rc-buggy users). And it is clear that commit improved
> "a lot" how configure detects smbclient; just as clear as it brakes
> detection for many current users.

News flash: compiling from source is user-unfriendly.

> It is a normal thing in open source project to revert commit that broke
> previous working state. But, ones with power to commit will decide
> eventually.

Exposing a (latent) bug is not the same as introducing the bug ("breaking"). 
The bug was introduced when Debian samba maintainers failed to distribute the 
pkg-config file.

There are enough bugs and hacks in VLC to keep us busy; we have better things 
to do that take care of bugs in other software.

-- 
Rémi Denis-Courmont
http://www.remlab.net/